Make ensure-go-installed work again (on macOS)#1129
Closed
staktrace wants to merge 2 commits intogithub:masterfrom
Closed
Make ensure-go-installed work again (on macOS)#1129staktrace wants to merge 2 commits intogithub:masterfrom
staktrace wants to merge 2 commits intogithub:masterfrom
Conversation
PR github#966 updated the PREFERRED_GO_VERSION from go1.14.7 to go1.16.4 but didn't update the corresponding binary checksums. The checksums can be found at https://go.dev/dl/ Additionally, the package file inside has changed and requires updating.
staktrace
changed the title
timvaillancourt
approved these changes
Jun 2, 2022
Collaborator
timvaillancourt
left a comment
timvaillancourt
left a comment
There was a problem hiding this comment.
@staktrace d'oh 🤦. Thanks for this PR!
New checksums LGTM 👍:
tim@Tims-MacBook-Pro gh-ost % curl -sLo - https://dl.google.com/go/go1.16.4.darwin-amd64.pkg | shasum -a 256
9f9b940d0f4b3ac764f0a33d78384a87b804aab29d1aacbdc9bca3a3480e9272 -
tim@Tims-MacBook-Pro gh-ost % curl -sLo - https://dl.google.com/go/go1.16.4.linux-amd64.tar.gz | shasum -a 256
7154e88f5a8047aad4b80ebace58a059e36e7e2e4eb3b383127a28c711b4ff59 -
Collaborator
|
cc @dm-2 / @rashiq as I can't merge this due to the outstanding |
Collaborator
|
Another PR in the next release duplicates this. Closing in favour of #1136 👍 Thanks for the issue and PR 🙇 |
ghost
removed this from the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #966 updated the PREFERRED_GO_VERSION from go1.14.7
to go1.16.4 but didn't update the corresponding binary
checksums. The checksums can be found at https://go.dev/dl/
Additionally, the package file inside has changed and
requires updating.
Fixes issue: #1128